antfu / antfu/node-modules-inspector

Fails to detect MIT license in require-like package

Open
#145 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2.9k
Forks
90
Avg merge
2d 3h
Merged PRs (30d)
9

Description

Describe the bug

The require-like package is licensed under the MIT license; this is specified both in package.json and in the License file, and indeed that is recognized by npmjs.com. However, node-modules-inspector fails to recognize this.

Reproduction

Visit https://node-modules.dev/report/licenses#install=require-like and confirm that the package's license is listed as being in the category

System Info
Checked online, in https://node-modules.dev/report/licenses#install=require-like.
Used Package Manager

pnpm

Validations
  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
Contributions
  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the report at node-modules.dev/report/licenses#install=require-like and compare require-like's package.json and License files, which are linked in the issue. Trace the license-detection entry point and add coverage for this package; done means its MIT license is no longer categorized as .

Written by the indexing model from the issue text.

Assessment

Tech stack
nodejs, typescript
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.