ansys / ansys/pyfluent

Encapsulate the static info to avoid string based invocations

Open
#5,312 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
497
Forks
77
Avg merge
22h 37m
Merged PRs (30d)
45

Description

https://github.com/ansys/pyfluent/pull/5287#issuecomment-5167115908

Based on the above discussion:
1. The string based invocations can be avoided by encapsulations
2. Put the dirty code in the v0.

Later when v0's backwards compatibility is resolved (i.e. v0 is removed), we will not have this issue at all.

Contributor guide

Open the contributing guide

Research direction

Start with the discussion in PR 5287, especially the referenced issue comment, to identify the static information and string-based invocations in scope. Determine how the encapsulation should coexist with the v0 compatibility code; done means the targeted string-based invocations are avoided without resolving the broader v0 backwards-compatibility work.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend-api-design
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.