ansys / ansys/pyfluent

Refactoring of the launcher

Open
#5,245 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
497
Forks
77
Avg merge
22h 37m
Merged PRs (30d)
45

Description

> Similar to the earlier conversations on this method (see below), this continues a pattern I've flagged before: accumulation of low-level, untested branching logic. I understand this follows the existing style of the method, but each addition makes the eventual refactor larger and the method harder to review as a whole.
>
> I'd like to see argument-validation branches like this (and the timeout-string construction from before) extracted into small, testable methods rather than added inline. Given this has come up multiple times now, including in internal meetings, please treat this as a standing convention going forward, not a case-by-case judgment call.
>
> Image
>
> Final changes to the same method in same PR:
>
> Image

_Originally posted by @seanpearsonuk in [#4990](https://github.com/ansys/pyfluent/pull/4990/changes#r3550231986)_

Contributor guide

Open the contributing guide

Research direction

The payload does not name a file, test, or launcher entry point. Start by locating the launcher method and reviewing the related changes in PR #4990, then identify the argument-validation branches and timeout-string construction mentioned here. Done means those pieces are separated into small, testable methods without changing the launcher's behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.