Extraneous sleep call
- Dominant language
- Python
- Stars
- 497
- Forks
- 77
- Avg merge
- 22h 37m
- Merged PRs (30d)
- 45
Description
This is in `launcher_utils.py`:
```Python
def _await_fluent_launch(
server_info_file_name: str, start_timeout: int, sifile_last_mtime: float
):
"""Wait for successful fluent launch or raise an error."""
while True:
if Path(server_info_file_name).stat().st_mtime > sifile_last_mtime:
time.sleep(1) # <--- should not sleep here
logger.info("Fluent has been successfully launched.")
break
if start_timeout == 0:
raise TimeoutError("The launch process has timed out.")
time.sleep(1)
start_timeout -= 1
logger.info("Waiting for Fluent to launch...")
if start_timeout >= 0:
logger.info(f"...{start_timeout} seconds remaining")
```
Contributor guide
Research direction
Open launcher_utils.py and start at _await_fluent_launch, where the issue marks an unnecessary sleep after the server-info file changes. Remove that delay and verify that the launch-success path proceeds immediately; run the relevant launcher tests if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100