ansys / ansys/actions

PyWin32 license

Open
#370 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
19
Forks
7
Avg merge
2d 4h
Merged PRs (30d)
50

Description

I see that pyWin32 is marked as manually excluded from license checking, with the logic that it's a PSF licensed package. This is definitely not the case, the code is a mess of conflicting license terms.

I'm not sure what we're using the license check action for, and what we claim it to be, but if anyone is using it as justification for legal purposes we need to be aware of the issues.

For example:
The adodbapi package is LGPL 2.1 - https://github.com/mhammond/pywin32/blob/main/adodbapi/adodbapi.py
The Scintilla vendored package is MIT - https://github.com/mhammond/pywin32/blob/main/Pythonwin/Scintilla/License.txt
The com package is old style BSD - https://github.com/mhammond/pywin32/blob/main/com/License.txt

Contributor guide

Open the contributing guide

Research direction

Start by locating the license-check workflow and its manual pyWin32 exclusion, then review the cited upstream files: adodbapi/adodbapi.py, Pythonwin/Scintilla/License.txt, and com/License.txt. Confirm what the action is intended to guarantee and define the expected handling of these licenses before changing the check.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, python
Domain
ci-cd, devops
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.