ansible / ansible/pylibssh

Consider normalization of log levels passed to set_log_level()

Open
#800 0 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Cython
Stars
79
Forks
47
Avg merge
1d 11h
Merged PRs (30d)
6

Description

The #597 implements configuring specific libssh log levels, but it would be good to be able to accept arbitrary values from the python logging system range and normalize to closest value somehow.

Looks like this is untested. But also, it might make more sense to allow arbitrary levels to be normalized to the closest known value as the Python logging infra does not have a problem with intermediate logging levels as long as they are integers.

_Originally posted by @webknjaz in https://github.com/ansible/pylibssh/pull/597#discussion_r2813078766_

Contributor guide

Open the contributing guide

Research direction

Start at the set_log_level() implementation and review the configuration work from PR #597, then compare its accepted values with the integer range used by Python logging. Check the existing test coverage, which the issue says is missing. Done means arbitrary integer levels are consistently normalized to the closest supported libssh level and covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.