ansible-community / ansible-community/github-docs-build

Surge workflow - secret availability is not tested

Open
#5 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jinja
Stars
13
Forks
10
Avg merge
10h 14m
Merged PRs (30d)
1

Description

The surge workflow requires a secret, however we don't actually test that the secret is available. As a result, when a repo which uses the workflow successfully (like `community.hashi_vault`) is forked, the [workflow in the fork fails](https://github.com/briantist/community.hashi_vault/actions/runs/1671361849) unless the fork's owner sets a working secret.

I think the shared workflow should check for the existence of the secret first of all (GitHub does not provide a nice way to do this but I think we can compare to empty string), and it should provide an option that controls what to do when the secret is missing (skip tasks and be "successful" or fail), so that the caller can decide how to handle it.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by inspecting the shared surge workflow and how callers configure it, then reproduce the fork scenario with the secret unavailable. Done means the workflow detects a missing secret and callers can choose whether to skip the tasks successfully or fail; verify both behaviors against the linked fork failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd, devops
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.