ansible-collections / ansible-collections/google.cloud

modules/gcp_compute_instance_group_info.py doesn't return "instances"

Open
#341 3 comments 0 reactions 0 assignees View on GitHub
stale
Dominant language
Python
Stars
105
Forks
144
Avg merge
5d 10h
Merged PRs (30d)
4

Description

Current implementation if https://github.com/ansible-collections/google.cloud/blob/master/plugins/modules/gcp_compute_instance_group_info.py mentions return parameter:

```
instances:
description:
- The list of instances associated with this InstanceGroup.
- All instances must be created before being added to an InstanceGroup.
- All instances not in this list will be removed from the InstanceGroup and
will not be deleted.
- Only the full identifier of the instance will be returned.
returned: success
type: list
```

but there is no calls to ` POST /compute/v1/projects/{project}/zones/{zone}/instanceGroups/{resourceId}/listInstances`.

See https://cloud.google.com/compute/docs/reference/rest/v1#rest-resource:-v1.instancegroups

The only file with a call to `.../instanceGroups/{resourceId}/listInstances` is `gcp_compute_instance_group.py` and it modify state...

Contributor guide

Open the contributing guide

Research direction

Start with plugins/modules/gcp_compute_instance_group_info.py and compare its implementation with the listInstances call in gcp_compute_instance_group.py. Check the Google Compute Engine instanceGroups listInstances REST endpoint and confirm that successful module output includes the documented instances list without modifying state.

Written by the indexing model from the issue text.

Assessment

Tech stack
ansible, gcp, python
Domain
api, cloud
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.