anomaly / anomaly/gallagher

Incorrect type in `EndpointConfig` for `endpoint` and `endpoint_follow` configuration

Aperta
#72 0 commenti 0 reazioni 1 assegnatario Rivendicata da @devraj Vedi su GitHub
bug
Lingua principale
Python
Stelle
17
Fork
2
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

**Describe the bug**
The `EndpointConfig` class has the following definition:

```
@dataclass
class EndpointConfig:
endpoint: str # partial path to the endpoint e.g. day_category
endpoint_follow: str | None = None # partial path to the follow endpoint
```

which was correct when the project started, however through the lifecycle we have moved to using `OptionalHref` classes to reference the URLs:

```python
class FeatureEventsRef(AppBaseModel):
divisions: OptionalHrefMixin = None
event_groups: OptionalHrefMixin = None
events: OptionalHrefMixin = None
updates: OptionalHrefMixin = None
```

while this won't raise an issue as `href` is a wrapper on `str`, this should be properly retrofitted to represent the right type.

**To Reproduce**
Not applicable as these values are internally populated on discovery.

**Expected behavior**
NA

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.