anomaly / anomaly/gallagher

Relax rules in `EventSummary` DTO

Ouverte
#71 0 commentaires 0 réactions 1 personne assignée Réclamée par @devraj Voir sur GitHub
bug documentation
Langage dominant
Python
Étoiles
17
Forks
2
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

**Describe the bug**
While working with a client's Command Centre instance I found that a number of `EventSummary` (while tailing the `/events/updates` endpoint)objects were failing to parse due to missing attributes or the attributes being too strict.

**To Reproduce**
Steps to reproduce the behavior:
1. Run the test_events.py
2. Or try and validate the response from `/api/events/updates` using `EventSummary`

**Expected behavior**
The validation should pass, instead the following fail:
- `operator.href` required and should be optional
- `card.id` is not sent down in the response
- `modified_item.href` is required and it not sent down
- `source.href` should be optional

**Screenshots**
NA

**Desktop (please complete the following information):**
NA

**Smartphone (please complete the following information):**
NA

**Additional context**
- See also #20
- Command Centre was running version `8.9`
- Before we go down debugging this, can we please make sure that the `follow` command is targeting the right URLs.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.