annoviko / annoviko/pyclustering

ROCK implementation error

Open
#680 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.2k
Forks
262
PR merge metrics
No merged PRs in 30d

Description

There is an error in the implementation of ROCK algorithm. In the original paper describing the algorithm, the authors stress the fact that they use the number of links (defined as common neighbours) between clusters, rather than the number of neighbours, when they chose which clusters should be merged. They say one can obtain a matrix of links by multiplying the adjacency matrix by itself. In the current implementation, the goodness measure uses the adjacency matrix where it should use the links matrix (= adjacency_matrix ^ 2).

I am planning to submit a pull request soon to correct this.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.