Improve invalid FSRS params message
- Dominant language
- Rust
- Stars
- 31.2k
- Forks
- 3.2k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 72
Description
This request is basically for future-proofing because saving deck options with invalid parameters isn't possible.
As David said, we need a reasonable solution to handle the following cases
- AnkiDroid > Anki Desktop
AnkiDroid auto-updates and the user does not want to update Anki due to addon compat. Anki Desktop is broken
- AnkiDroid < Anki Desktop
A user does not want to/cannot update AnkiDroid (e.g. due to regressions, or their device no longer being supported). AnkiDroid is broken
To be fair, we can replace AnkiDroid with AnkiMobile here and the arguments remain valid. So, it is truly an ecosystem compatibility issue.
The main issue is the UX
> The current error provides the user neither explanation nor context (what is a parameter), nor action to take to fix the issue
>
>
Though I am happy with the solution that Damien proposed in https://github.com/ankidroid/Anki-Android/issues/17236#issuecomment-2408394699, David (and I) think that we should go a step ahead to make the UX better.
### Proposed solution:
If the user has invalid parameters, the error message in the reviewer should have a button to optimize the parameters.
Contributor guide
Research direction
Start with the reviewer error path that currently reports invalid FSRS parameters, then review the linked AnkiDroid discussion for the proposed UX. Done means the reviewer explains the invalid-parameter problem and offers an action to optimize the parameters.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- desktop-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100