anitab-org / anitab-org/mentorship-android

Add NetworkStateReceiver

Đang mở
#419 6 bình luận 0 reaction 1 người được giao Được @CodeChamp-SS nhận Xem trên GitHub
Category: Coding Type: Enhancement
Ngôn ngữ chính
Kotlin
Star
169
Fork
378
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

**Is your feature request related to a problem? Please describe.**
As of now, the user can't use the app without the internet and she/he gets a SnackBar message saying: "Please check your internet connection." And the problem is that when the user turns mobile data / wifi on, she/he needs to update the current fragment by clicking on it. It would be more user-friendly if the data would be loaded automatically.

**Describe the solution you'd like**
A NetworkStateReceiver that will notify all ViewModels when there is an internet connection and inside of each ViewModel it should refresh / try to load data one more time.

**Describe alternatives you've considered**
We could also let the user save all the data and use the app offline, but I think that this need to be discussed on Slack and even if implement that, we would still need a NetworkStateReceiver for at lease MembersFragment.

**Gif**
![20191227_011900](https://user-images.githubusercontent.com/34242059/71494542-36c72a80-2848-11ea-9d3c-b96583974f0b.gif)

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.