anitab-org / anitab-org/anitab-forms-web

Bug: Streamwise messages not showing on zulip stat card to admin

Open
#72 22 comments 0 reactions 1 assignee Assigned to @ASP124 View on GitHub
Category: Coding First Timers Only Hacktoberfest
Dominant language
JavaScript
Stars
44
Forks
81
PR merge metrics
No merged PRs in 30d

Description

### Describe the bug
Streamwise messages are not showing on zulip stat to admin because the condition to check streamwise messages is wrong.
We need to delete this condition of checking all streamwise messages by checking the message in the newcomer stream, as it is not required. To test the message

### To Reproduce
Steps to reproduce the behavior:
1. Go to http://localhost:8000/admin/osp/userinformation/
2. Edit one of the admin user-information and insert 345277 in zulip id.
3. Now go to this http://localhost:3000/ and log in using the credentials of the user which you have edited previously.
4. Reload the zulip stats and now you can see that streamwise messages do not show up.

### Expected behavior
Streamwise messages do not show up when the student has no message in the newcomer stream.

### Screenshots
![image](https://user-images.githubusercontent.com/56037184/107190877-649e0d00-6a11-11eb-9c68-92f6475b69e7.png)

### Desktop (please complete the following information):
- OS: Ubuntu
- Browser: Chrome
- Version: _

### How to solve
To solve this issue remove the condition of checking the stream messages by checking message in newcomer stream.
https://github.com/anitab-org/open-source-programs-web/blob/ab18727af5a5e30829e4d07935a218c6d8a02762/src/components/Zulip.js#L39-L51

I have tested by removing it, it is working fine.

### Time Required to solve this issue
- 10 to 15 minutes.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.