Consider adding a wrapper around `jasmine_node_test` rule
- Dominant language
- JavaScript
- Stars
- 77
- Forks
- 83
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 37
Description
PR https://github.com/angular/angular/pull/44505 updated angular/angular repo to use ES2015 instead of ES5. The mentioned change revealed that there is a duplication in a lot of places where the `bootstrap` is defined, for example:
```
jasmine_node_test(
bootstrap = ["//tools/testing:node_no_angular_es2015"],
```
or:
```
jasmine_node_test(
bootstrap = ["//tools/testing:node_es2015"],
```
This makes further ES version upgrades quite error-prone (and time-consuming), since we need to change ~100 files.
The proposal is to create a couple wrappers, for example:
- ng_node_test
- no_ng_node_test
and specify `bootstrap` there by default (and allow overrides), so that it's easier to update ES version.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the jasmine_node_test rule and the repeated bootstrap call sites shown in the issue. Define the proposed ng_node_test and no_ng_node_test entry points with default bootstrap values and override support, then verify that existing call sites can use them and that future ES-version changes need fewer edits.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- build-system, testing
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100