angular / angular/components

ripples (mat-checkbox, mat-option, etc...) cause scrolling in dialog

Open
#8,798 15 comments 17 reactions 0 assignees View on GitHub
area: material/checkbox area: material/dialog G needs: discussion P4
Dominant language
TypeScript
Stars
25k
Forks
6.8k
Avg merge
1d 8h
Merged PRs (30d)
91

Description

#### Bug, feature request, or proposal:
If a mat-checkbox is the last element in a mat-dialog-content it will cause the dialog to to have a scrollbar, even if the content has not reached it's max height.

#### What is the expected behavior?

There should be no scrolling if the dialog has room to grow.

#### What is the current behavior?

The dialog scrolls when a mat-checkbox is present.

#### What are the steps to reproduce?
https://stackblitz.com/edit/angular-material2-issue-dhosn1

Click the button, notice the dialog.

#### What is the use-case or motivation for changing an existing behavior?

It looks bad.

#### Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Whatever is used by stackblitz

#### Is there anything else we should know?

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue in the linked StackBlitz example, then inspect the interaction between mat-dialog-content and the mat-checkbox ripple when the checkbox is the last element. Done means a dialog with room to grow no longer gets a scrollbar when a mat-checkbox or similar rippled component is present.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.