[mat-menu] support horizontal (xPosition) overlap detection
- Dominant language
- TypeScript
- Stars
- 25k
- Forks
- 6.8k
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 91
Description
#### Bug, feature request, or proposal:
feature
#### What is the expected behavior?
When [overlapTrigger] is false the menu will NOT overlap on the horizontal axis (xPosition)
#### What is the current behavior?
The horizontal axis is overlapping the triggering element wether overlapTrigger is true/false.
#### What is the use-case or motivation for changing an existing behavior?
Per the docs, the overlapTrigger should respect both x and y.
It is also a valid requirement.
#### Which versions of Angular, Material, OS, TypeScript, browsers are affected?
angular 5, material 5.0.0-rc0
Contributor guide
Research direction
Start at the Angular Material mat-menu positioning entry point and trace how overlapTrigger currently handles the y axis versus xPosition. Run the relevant menu tests, then verify that setting overlapTrigger to false prevents horizontal overlap with the triggering element while preserving the existing behavior when it is true.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100