angular / angular/components

Scope dialog to a subsection of the DOM rather than the whole page

Open
#3,221 12 comments 10 reactions 0 assignees View on GitHub
area: material/dialog feature P5
Dominant language
TypeScript
Stars
25k
Forks
6.8k
Avg merge
1d 8h
Merged PRs (30d)
91

Description

#### Bug, feature request, or proposal:
Feature

#### What is the expected behavior?
It would be nice to have an option that set how a modal should be opened.

For example with material for AngularJS : https://material.angularjs.org/latest/demo/dialog

![image](https://cloud.githubusercontent.com/assets/4950209/23166647/b2c49986-f841-11e6-9fa5-0b313d86abfa.png)

Give :
![image](https://cloud.githubusercontent.com/assets/4950209/23166658/be54848c-f841-11e6-96e1-9cd5d8440c25.png)

(it's not opened on the whole page).

There's an option for that :
![image](https://cloud.githubusercontent.com/assets/4950209/23166677/d4b6e332-f841-11e6-9904-b0678e27e5a5.png)

(gives the following)
![image](https://cloud.githubusercontent.com/assets/4950209/23166699/ecabff5e-f841-11e6-8fc1-cceb32b38607.png)

#### What is the current behavior?
A modal is opened in full page

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Start by locating the dialog implementation and inspecting how it currently opens over the full page. Done means an option can constrain the modal to a chosen DOM subsection, matching the provided AngularJS examples.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.