angular / angular/components

bug(mat-slide-toggle): disableRipple not causing any visual changes

Open
#28,679 4 comments 5 reactions 0 assignees View on GitHub
area: material/slide-toggle P4
Dominant language
TypeScript
Stars
25k
Forks
6.8k
Avg merge
1d 8h
Merged PRs (30d)
91

Description

### Is this a regression?

- [X] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

It looks like `disableRipple` was used to prevent the ripple animation (ripple based on where in the touch target you clicked) in the legacy components, but now that doesn't seem to show up anymore. So it seems that setting `disableRipple` isn't causing any difference now.

### Reproduction

StackBlitz link: https://stackblitz.com/edit/aakbph?file=src%2Fexample%2Fslide-toggle-overview-example.html

### Expected Behavior

Setting `disableRipple` to true would cause a visual difference upon clicking the slide toggle handle.

### Actual Behavior

No viusal change

### Environment

- Angular: 17.2.0-rc.0
- CDK/Material: 17.2.0-rc.0
- Browser(s): Chrome
- Operating System (e.g. Windows, macOS, Ubuntu): macOS

Contributor guide

Open the contributing guide

Research direction

Open the linked StackBlitz and start with src/example/slide-toggle-overview-example.html; reproduce the click behavior in Chrome and trace how disableRipple is used by mat-slide-toggle. Done means setting disableRipple to true produces a visible difference in the slide-toggle handle behavior, with the regression covered by the relevant project checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.