angular / angular/components

bug(material/chip): textContent of any HTML element inside mat-chip-row is being appended to FormControl value on focus out (blur) event

Open
#27,839 1 comment 0 reactions 0 assignees View on GitHub
area: material/chips P3
Dominant language
TypeScript
Stars
25k
Forks
6.8k
Avg merge
1d 8h
Merged PRs (30d)
91

Description

### Is this a regression?

- [X] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

14

### Description

When there is any HTML element inside ``, or even just the matChipRemove button is wrapped inside some `` (like with `*ngIf`, checking if the user has the privilege to delete), then the whole chip-row's value contains this element's textContent (button with `cancel` in this case) after focusing out of the component.

So for example, value `["Apple"]` becomes `["Apple cancel"]` (because `cancel` is part of ``'s textContent).

```

{{ fruit }}


cancel

```

(when `matChipRemove` button is not wrapped inside `` or any other HTML element then its textContent is being ignored, which, I guess, is correct behavior)

### Reproduction

StackBlitz link:
https://stackblitz.com/edit/ovb2sn-s41kjs?file=src%2Fapp%2Fchips-autocomplete-example.html,src%2Fapp%2Fchips-autocomplete-example.ts

Steps to reproduce:
Click on the text input and then focus it out.
This will run Material's blur/focusOut code and update the form control value with the chips' textContent which becomes `["Apple cancel"]`.
More focus in/out clicks will keep appending ` cancel` to the form control's value.

### Expected Behavior

Not appending HTML elements' textContent to chip's form control value

### Actual Behavior

HTML element's textContent is being appended to chip's form control value

### Environment

- Angular: 15+
- CDK/Material: 15+
- Browser(s): Any browser
- Operating System (e.g. Windows, macOS, Ubuntu): Any OS

Contributor guide

Open the contributing guide

Research direction

Start with the reproduction files src/app/chips-autocomplete-example.html and src/app/chips-autocomplete-example.ts, then follow the Material blur/focusOut behavior described in the issue. Confirm that focusing out does not append nested HTML textContent to the chip form-control value, including when matChipRemove is wrapped in ng-container.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.