bug(MatInput): read-only inputs are not considered focused
- Dominant language
- TypeScript
- Stars
- 25k
- Forks
- 6.8k
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 91
Description
#### Reproduction
[StackBlitz](https://stackblitz.com/edit/focused-readonly-input-bug)
Steps to reproduce:
1. Use the toggle to place the input in a read-only state
2. Tab to or click on the input to give it focus
3. Observe that the input has focus, but `MatInput` does not report it as focused
#### Expected Behavior
According to the Material [Text fields spec -> Read-only fields](https://material.io/components/text-fields#input-types)
>A read-only text field is styled the same as a regular text field.
Read-only inputs should receive the same focus styles as regular inputs. The `MatFormField` component conditionally applies focus styles (`mat-focused` class) based on the `focused` property of the `MatInput`.
https://github.com/angular/components/blob/master/src/material/form-field/form-field.ts#L139
When a read-only input is focused, `MatInput` should report it as focused to ensure focus styles are applied correctly.
#### Actual Behavior
`MatInput` filters out focus events on read-only inputs, always reporting them as not focused.
https://github.com/angular/components/blob/master/src/material/input/input.ts#L344
This results in the `mat-focused` class never being applied to `MatFormField`'s that wrap read-only inputs.
#### Environment
- Angular: 10.2.3
- CDK/Material: 10.2.7
- Browser(s): N/A
- Operating System (e.g. Windows, macOS, Ubuntu): N/A
Contributor guide
Research direction
Reproduce the behavior using the linked StackBlitz, then inspect src/material/input/input.ts around line 344 and src/material/form-field/form-field.ts around line 139. Confirm that focusing a read-only input is reported and that the surrounding MatFormField receives the mat-focused class and corresponding focus styles.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100