feat(datepicker): expose the validators that the datepicker uses internally as a public API
- Dominant language
- TypeScript
- Stars
- 25k
- Forks
- 6.8k
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 91
Description
#### Reproduction
https://stackblitz.com/edit/angular-inex9i?file=app%2Fdatepicker-formats-example.ts
#### Steps to reproduce
1. Add a MatDatePicker to a component and bind it to a Reactive form control
2. Ensure you are reporting the built-in parse error (matDatepickerParse) using mat-error
3. Type in a bad date and see the parse error.
4. Call setValidators() on your reactive form control. It doesn't matter what is sent to setValidators
5. Enter invalid data and you will no longer see matDatepickerParse reported
#### Expected Behavior
Parsing errors after calling setValidators() should continue to report parsing errors
#### Actual Behavior
Parsing errors are no longer reported.
#### Additional Information
The provided DateAdapter (custom or not) is still used. However, since [datepicker-input](https://github.com/angular/components/blob/917a52e03cca1b3568d29094bbf430846ba1c3c9/src/material/datepicker/datepicker-input.ts) will provide a null value if the provided DateAdapter says the inputted date is invalid, you cannot workaround this issue with a custom validator.
Many complex forms may have conditional validation so using setValidators is completely expected.
#### Environment
- Angular: 8.0.0
- CDK/Material: 8.0.1
- Browser(s): Google Chrome 73.0.3683.75 (Official Build) (64-bit)
- Operating System Windows 10 64-bit
Contributor guide
Research direction
Start with the linked reproduction and src/material/datepicker/datepicker-input.ts, focusing on how invalid adapter input and reactive-form validators interact. The change is done when the datepicker's internal validators are available through a public API and matDatepickerParse errors still appear after setValidators() is called.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100