angular / angular/angularfire

Unable to deploy on windows using ng deploy

Open
#3,250 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
7.8k
Forks
2.2k
Avg merge
22h 28m
Merged PRs (30d)
6

Description

### Version info

**Angular:** 13.3.0

**Firebase:** 9.6.10

**AngularFire:** 7.2.1

**Node:** 16.13.2

**Operating System:** Windows 11

### How to reproduce these conditions

**Unable to deploy on windows using ng deploy**

Hi, when I am trying to deploy the my app which have SSR enabled for firebase functions using ng deploy it just doesn't work.
Deployment just fails with error message : `Your code contains errors while deploying function ssr_app`
After many hours of searching I found that it is creating wrong package.json file it has a dependency stating myprojectname with value file:../../.. which looks like this exactly `"my-project": "file:../../.."`
This error is only being produced on windows machine, same doesn't happen on mac. Also manually removing that line and running firebase deploy does the job.

### Debug output

** Errors in the JavaScript console **

** Output from `firebase.database().enableLogging(true);` **

** Screenshots **
![angular-err](https://user-images.githubusercontent.com/10049774/179815463-d4197dec-1e16-4be6-9d80-97c39917cb51.jpg)

### Expected behavior

It should generate package.json correctly and invalid dependency should not be added in it.

### Actual behavior

It is adding an invalid dependency in generated function directory's package.json file which looks like this `"my-project": "file:../../.."`

Contributor guide

Open the contributing guide

Research direction

Reproduce ng deploy on Windows 11 with an SSR-enabled Firebase functions app using the versions listed in the issue. Inspect the generated function directory's package.json and compare it with deployment on macOS. Done means the invalid file:../../.. dependency is not generated and deployment succeeds without manually editing package.json.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, firebase, typescript
Domain
cloud, devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.