angular / angular/angularfire

"2. Documents in AngularFirestore" needs an `undefined`

Open
#3,201 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
7.8k
Forks
2.2k
Avg merge
22h 28m
Merged PRs (30d)
6

Description

In

https://github.com/angular/angularfire/blob/master/docs/firestore/documents.md

line 17 is:

```ts
item: Observable;
```

should be

```ts
item: Observable;
```

Everything else works perfectly. Thanks!

### Version info

**Angular:**

**Firebase:**

**AngularFire:**

**Other (e.g. Ionic/Cordova, Node, browser, operating system):**

### How to reproduce these conditions

**Failing test unit, Stackblitz demonstrating the problem**

**Steps to set up and reproduce**

**Sample data and security rules**

### Debug output

** Errors in the JavaScript console **

** Output from `firebase.database().enableLogging(true);` **

** Screenshots **

### Expected behavior

### Actual behavior

Contributor guide

Open the contributing guide

Research direction

Open docs/firestore/documents.md and inspect line 17, where the AngularFirestore document example declares item. Update the Observable type to include undefined, then verify the example matches the requested type and remains valid TypeScript.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, firebase, typescript
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.