angular / angular/angularfire

collection function has no generic type

Open
#3,073 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
TypeScript
Stars
7.8k
Forks
2.2k
Avg merge
22h 28m
Merged PRs (30d)
6

Description

### Version info

**Angular:**
12.2.0
**Firebase:**
9.4.0
**AngularFire:**
7.2.0

### How to reproduce these conditions
import {
collection,
} from '@angular/fire/firestore';

### Expected behavior

collection suppose to receive generic type of collection documents interface. as stated in docs

import { collection } from '@angular/fire/firestore';
collection(firestore, 'foo') // CollectionReference

### Actual behavior
generic type is not configured, hence causing a problem on passing to update and doc functions with the generic type of the interface set
![Code_Y7nW5tuIqt](https://user-images.githubusercontent.com/1358030/142910550-ba3c36c6-e8b3-4b3b-b9b3-b0a068e9aca9.png)
![chrome_9x67l0gpG5](https://user-images.githubusercontent.com/1358030/142910580-b4d0d876-9132-49ab-a3e3-80b033f47b65.png)

.

Contributor guide

Open the contributing guide

Research direction

Start at the @angular/fire/firestore collection entry point and inspect how its return type is declared. Compare it with the documented collection(firestore, 'foo') usage, then check how the resulting type is passed to update and doc. Done means collection accepts the generic type and preserves it for those calls.

Written by the indexing model from the issue text.

Assessment

Tech stack
firebase, typescript
Domain
backend, databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.