Support for list of allowed licenses for 3rdpartylicenses.txt
- Dominant language
- TypeScript
- Stars
- 27k
- Forks
- 11.8k
- Avg merge
- 14h 23m
- Merged PRs (30d)
- 162
Description
### Command
build
### Description
When running `ng build` angular will generate the file `3rdpartylicenses.txt` which contains information about 3rd party licenses included in the build result.
While this is awesome, it would be good to have an option to allow licenses that can be included in the build. For example `MIT`, `Apache-2.0` and as soon as a license which is not allowed is included, the build should fail.
https://github.com/angular/angular-cli/blob/ec7dd59e38f84db91f5a2e4ed653bbc54cb82d54/packages/angular/build/src/builders/application/execute-build.ts#L247-L253
### Describe the solution you'd like
In go, the package https://github.com/google/go-licenses for example supports `--allowed_licenses=`. As soon as a different license is found, the build fails. also [php](https://github.com/dominikb/composer-license-checker) or other languages have tools for this.
### Describe alternatives you've considered
Currently I'm trying to implement this using the npm package: https://www.npmjs.com/package/@onebeyond/license-checker
The issue is, that it includes a lot of npm packages which are not part of the final angular app - such as `argparse` for example.
Contributor guide
Research direction
Start at packages/angular/build/src/builders/application/execute-build.ts around the 3rdpartylicenses.txt generation linked in the issue, then trace how licenses from the final build are collected. Define how an allowed comma-separated license list is supplied to ng build and how a disallowed license causes failure. Done means the build checks the generated build licenses rather than unrelated installed packages.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- build-system, cli
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100