Replace favicon.ico in favor of png in src/assets
- Dominant language
- TypeScript
- Stars
- 27k
- Forks
- 11.8k
- Avg merge
- 14h 23m
- Merged PRs (30d)
- 162
Description
### Bug Report or Feature Request (mark with an `x`)
```
- [ ] bug report -> please search issues before submitting
- [x] feature request
```
### Area
```
- [ ] devkit
- [x] schematics
```
### Desired functionality
favicon.ico is outdated and obsolete relic from the 90s. Browsers for the past 2decades have supported png favicons. Additionally, while it's fairly easy now to generate a favicon.ico, it's just not needed or used anymore.
There's no reason imo to include favicon.ico, even for "compatibility". Removing the favicon.ico will also remove the entries needed in angular.json and remove the only asset stored outside of src/assets.
It should be replaced in favor of modern favicon methods. PWAs should use manifest.json
```
```
Note: svg doesn't have full browser support.
We haven't needed favicon.ico in years, but it's still widely used and implemented, even though all browsers support modern methods.
Contributor guide
Research direction
Start by tracing the schematic files that create the favicon and the related entries in angular.json, then inspect src/assets for the current icon. Confirm which modern PNG or manifest-based files the generated application should include, remove the obsolete favicon.ico references, and update the relevant schematic tests if they cover generated assets.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular
- Domain
- build-system, frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100