andywer / andywer/threads.js

yarn v3 PNP

Aperta
#423 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
TypeScript
Stelle
3.5k
Fork
173
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

It appears that using Yarn v3's PNP functionality causes the Worker to not load the actual file. If `nodeLinker` is set to `node-modules` in `.yarnrc.yml`, it works as expected.

This is the error I'm receiving
> Timeout: Did not receive an init message from worker after 10000ms. Make sure the worker calls expose().

The best I can tell, it's due to using `require` within the `resolveScriptPath` function. It might be worthwhile to look into [createRequire function](https://nodejs.org/api/module.html#module_module_createrequire_filename) as described in yarn's [rule book](https://yarnpkg.com/advanced/rulebook#packages-should-only-ever-require-what-they-formally-list-in-their-dependencies) on the topic
> If your package is something that automatically loads plugins (for example eslint), peer dependencies obviously aren't an option as you can't reasonably list all plugins. Instead, you should use the [createRequire function](https://nodejs.org/api/module.html#module_module_createrequire_filename) (or its [polyfill](https://github.com/nuxt-contrib/create-require)) to load plugins on behalf of the configuration file that lists the plugins to load - be it the package.json or a custom one like the .eslintrc.js file.

I haven't had a chance to debug it further, so I'm speculating the createRequire function will resolve the issue.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.