andywer / andywer/threads.js

Working around ERR_PACKAGE_PATH_NOT_EXPORTED

Aperta
#326 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
3.5k
Fork
173
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I'm trying to print your default thread size for a dry run purpose (without initialising a pool first).

```js
let {
dryRun,
threads = require('threads/dist/master/implementation').defaultPoolSize,
// ...
} = argv;

if (dryRun) {
console.log('threads', threads);
}
```

I'm having trouble updating to the latest version because of ERR_PACKAGE_PATH_NOT_EXPORTED. My workaround is:

```js
let {
dryRun,
threads,
// ...
} = argv;

let pool = Pool(() => spawn(new Worker('foo')), ...[threads].filter(Boolean));

if (dryRun) {
console.log('threads', pool.workers.length);
}
```

It works, but the original was more elegant. I know your implementation is simple and based on `cpus().length`, but I'd prefer not diverge from your default and start guessing wrong. What are your thoughts? Should a default config be exposed? If my workaround is what you recommend, feel free to close this issue. Thanks.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.