androidx / androidx/media

setMediaItem does not return a Future

Open
#97 1 comment 0 reactions 1 assignee View on GitHub

@marcbaechinger is already working on this.

Since Jul 1, 2022.

enhancement
Dominant language
Java
Stars
3k
Forks
955
Avg merge
12d 14h
Merged PRs (30d)
2

Description

While integrating media3 into a wear app, I ran into some issues with setMediaItem silently failing until I figured out that I can't just send a URI from the controller.

I see the internal code actually routes the error back to the controller via a Future; that Future is just dropped in MediaControllerImplBase instead of being returned up the call stack, and no errors are logged.

As a feature request, setMediaItem and other calls that could fail should return that info to the caller instead of silently dropping it.

See also:

https://github.com/androidx/media/issues/93
https://github.com/androidx/media/issues/43
https://github.com/androidx/media/issues/8

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.