`lib-exoplayer-ima` skip ad functionality no longer supported by IMA
@marcbaechinger is already working on this.
Since Dec 21, 2023.
- Dominant language
- Java
- Stars
- 3k
- Forks
- 955
- Avg merge
- 12d 14h
- Merged PRs (30d)
- 2
Description
Version
Media3 1.2.0
More version details
not version dependent
Devices that reproduce the issue
any
Devices that do not reproduce the issue
none
Reproducible in the demo app?
Yes
Reproduction steps
Very coarse steps, happy to provide more detail if needed:
- Extend sample to use
lib-exoplayer-imaextension without anadViewGroupin order to usecreateAudioAdDisplayContainer - schedule client side skippable ad, e.g.
https://pubads.g.doubleclick.net/gampad/ads?iu=/21775744923/external/single_preroll_skippable&sz=640x480&ciu_szs=300x250%2C728x90&gdfp_req=1&output=vast&unviewed_position_start=1&env=vp&impl=s&correlator= - play the ad until it is in skippable state (5 seconds for the sample tag)
- call
skipAd
Expected result
The ad should be skipped. The documentation on skipAd states that this should only be used for audio only ads.
In the past this also worked for non-audio only ads but given the documentation I guess it's intended that it does not work if a view is present.
The root cause for this behaviour change is a change on IMA side, see (1, 2) for reference.
Actual result
Ad does not skip
Media
Not dependent on main content, as skippable ad, https://pubads.g.doubleclick.net/gampad/ads?iu=/21775744923/external/single_preroll_skippable&sz=640x480&ciu_szs=300x250%2C728x90&gdfp_req=1&output=vast&unviewed_position_start=1&env=vp&impl=s&correlator= can be used.
Bug Report
- You will email the zip file produced by
adb bugreportto android-media-github@google.com after filing this issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.