androidx / androidx/media

DownloadService is hard to configure via Hilt

Open
#91 1 comment 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

enhancement needs triage
Dominant language
Java
Stars
3k
Forks
955
Avg merge
12d 14h
Merged PRs (30d)
2

Description

Because the constructor of DownloadService takes parameters instead of it being configured at some point before onCreate, it isn't possible to build a reusable DownloadService implementation and then customise via Hilt injection.

    DownloadService(
        downloadNotificationId,
        DEFAULT_FOREGROUND_NOTIFICATION_UPDATE_INTERVAL,
        channelId,
        downloadChannelNameResourceId,
        downloadChannelDescriptionResourceId
    ) {

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.