androidx / androidx/media

Support for apps to configure cea708 maxCount

Open
#833 1 comment 0 reactions 1 assignee View on GitHub

@icbaker is already working on this.

Since Nov 23, 2023.

enhancement low priority
Dominant language
Java
Stars
3k
Forks
955
Avg merge
12d 14h
Merged PRs (30d)
2

Description

When filing a feature request:

Replace the content in the sections below.

[REQUIRED] Use case description

Some streams have malformed closed caption data that don't configure the CC window with the correct rowCount or rowLock bits. This causes the CC data to render up to 15 rows (as currently configure in Cea708Decoder.CueInfoBuilder.MAXIMUM_ROW_COUNT = 15.

It would be ideal if the app can configure the MAXIMUM_ROW_COUNT as needed.

Proposed solution

A new API to allow the App to configure the MAXIMUM_ROW_COUNT used by Cea708Decoder.

Alternatives considered

It is possible to provided a custom Cea708Decoder using a custom RenderersFactory, SubtitleDecoderFactory and Cea708Decoder but it is a lot of code to maintain just to override a configuration value.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.