androidx / androidx/media

Implement proper support for PlayerView.onResume and PlayerView.onPause for multi-window mode

Open
#488 4 comments 0 reactions 1 assignee View on GitHub

@marcbaechinger is already working on this.

Since Jun 28, 2023.

enhancement
Dominant language
Java
Stars
3k
Forks
955
Avg merge
12d 14h
Merged PRs (30d)
2

Description

Use case description

Per the javadocs PlayerView.onResume() is recommended to be called in Activity.onStart(), or Activity.onResume() for API versions <= 23.

PlayerView.onPause() has similar logic.

This API level differentiation is meant to handle multi-window mode that was introduced in API 24.

Developers are expected to know how to handle this in their own code with API level checks.

Proposed solution

media3 / exoplayer library should instead handle these version differences internally so developers don't have to implement the API level checks in their own code.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.