androidx / androidx/media

SCTE-35 : timestamp adjustment is not used?

Open
#471 7 comments 0 reactions 1 assignee View on GitHub

@icbaker is already working on this.

Since Jun 26, 2023.

question
Dominant language
Java
Stars
3k
Forks
955
Avg merge
12d 14h
Merged PRs (30d)
2

Description

(Copy/paste from https://github.com/google/ExoPlayer/issues/11211 )

Hi,

I'm working on SCTE-35, it seems Metadata events (TimeSignalCommands) are not rendered at the right time, but earlier. I'm on ExoPlayer 2.18.6, I'm using DefaultRenderersFactory so MetadataRenderer.outputMetadataEarly is set to false.

I'm wondering if this is related to the fact that SpliceInfoDecoder does not use adjusted timestamps extracted from SpliceInsertCommand/TimeSignalCommand. Don't these adjusted timestamps should be used somewhere in the Metadata rendering chain for them to be fired at the right time?

Best regards

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.