androidx / androidx/media

Inconsistent UI hiding behavior when you tap to hide as opposed to letting it hide itself

Open
#366 6 comments 0 reactions 1 assignee View on GitHub

@marcbaechinger is already working on this.

Since May 2, 2023.

enhancement low priority
Dominant language
Java
Stars
3k
Forks
955
Avg merge
12d 14h
Merged PRs (30d)
2

Description

[REQUIRED] Use case description

This is on Justplayer using AndroidX Media 1.0.1 on Android 11 Stock.

  1. When allowing the UI to hide itself, most of the UI (the video overlay) goes away, but the progress line at the bottom, the nav buttons and the taskbar remain, and then they all finally hide. This is not preferred and just makes the UI hiding process last even longer by giving it 2 steps. The entire UI should vanish in 1 step, leaving only the video.

https://user-images.githubusercontent.com/49374058/235105695-d4a08a8c-0978-4af1-9a64-97dc76c1960a.mp4

  1. When you tap to hide the UI, the entire UI vanishes, It happens in 1 step. This is the preferred behavior and should always be how the UI is hidden.

https://user-images.githubusercontent.com/49374058/235105609-8f21b610-dd35-4513-b2f8-03ba8febdf27.mp4

Proposed solution

The entire UI should hide itself in 1 step when tapped or when allowed to hide itself. This makes the UI hide behavior more consistent. Please make the UI hide itself in 1 step when allowing the UI to hide itself. Allowing the UI to hide itself is what most people will do anyway when watching fullscreen video, so making that process happen in 1 step is important and saves the viewer from having to see the UI for more than they should have to.

Alternatives considered

N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.