androidx / androidx/media

Why does AnalyticsListener.onAudioPositionAdvancing report playoutStartTimeMs relative to system clock instead of position?

Open
#353 1 comment 0 reactions 1 assignee View on GitHub

@marcbaechinger is already working on this.

Since Apr 26, 2023.

needs triage question
Dominant language
Java
Stars
3k
Forks
955
Avg merge
12d 14h
Merged PRs (30d)
2

Description

I am comparing it to onPositionDiscontinuity in the sense that both are callbacks where EventTime may not be descriptive enough when it comes to positions.

onPositionDiscontinuity provides PositionInfo objects, however in order to know which position we advanced "from" in onAudioPositionAdvancing, the best that can be done (as far as I've been able to find) is using EventTime.currentPlaybackPositionMs. I find this both inconsistent with onPositionDiscontinuity (at least for implicit transitions) and problematic as said field seems to refer to the event time after having advanced audio position.

Is there a reason for this? Would it make more sense to go the onPositionDIscontinuity way and replace playoutStartTimeMs with a PositionInfo object describing the playout start position?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.