setArtworkUri could accept file:// and content:// Uris
@marcbaechinger is already working on this.
Since Mar 15, 2023.
- Dominant language
- Java
- Stars
- 3k
- Forks
- 955
- Avg merge
- 12d 14h
- Merged PRs (30d)
- 2
Description
Use case description
I develop and maintain an audio app that stores the covers for its media as files locally (in external storage). I want to use those local files as the artwork in a MediaItem.
Proposed solution
setArtworkUri in MediaMetadata.Builder could accept Uris with the scheme file:// and content://
Alternatives considered
(1) I can convert the local cover file into a ByteArray and pass that to setArtworkData. But that solution uses more memory compared to just setting that artwork Uri.
(2) setArtworkUri somewhat works with file://-Uris ... in the sense that the correct cover is displayed in the app's Notification. But MediaDataManager throws a FileNotFoundException (Permission denied). So I guess other clients of my app will not be able to see the cover.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.