Unable to customize media3 notification as per the tutorial
Open
Nobody has claimed this yet.
bug
- Dominant language
- Java
- Stars
- 3k
- Forks
- 955
- Avg merge
- 12d 14h
- Merged PRs (30d)
- 2
Description
Version
Media3 main branch
More version details
Following the tutorial
I am trying to customize the media3 notifiction controller.
And the tutorial does not work for me.
The "Save to favorites (heart icon)" does not show up the media3 notification.
Devices that reproduce the issue
Pixel 9A
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Not tested
Reproduction steps
The code is taken from the official documentation
public class PlaybackService extends MediaSessionService {
private static final SessionCommand CUSTOM_COMMAND_FAVORITES =
new SessionCommand("ACTION_FAVORITES", Bundle.EMPTY);
@Nullable private MediaSession mediaSession;
public void onCreate() {
super.onCreate();
CommandButton favoriteButton =
new CommandButton.Builder(CommandButton.ICON_HEART_UNFILLED)
.setDisplayName("Save to favorites")
.setSessionCommand(CUSTOM_COMMAND_FAVORITES)
.build();
Player player = new ExoPlayer.Builder(this).build();
// Build the session with a custom layout.
mediaSession =
new MediaSession.Builder(this, player)
.setCallback(new MyCallback())
.setMediaButtonPreferences(ImmutableList.of(favoriteButton))
.build();
}
private static class MyCallback implements MediaSession.Callback {
@Override
public ConnectionResult onConnect(
MediaSession session, MediaSession.ControllerInfo controller) {
// Set available player and session commands.
return new AcceptedResultBuilder(session)
.setAvailableSessionCommands(
ConnectionResult.DEFAULT_SESSION_COMMANDS.buildUpon()
.add(CUSTOM_COMMAND_FAVORITES)
.build())
.build();
}
public ListenableFuture onCustomCommand(
MediaSession session,
MediaSession.ControllerInfo controller,
SessionCommand customCommand,
Bundle args) {
if (customCommand.customAction.equals(CUSTOM_COMMAND_FAVORITES.customAction)) {
// Do custom logic here
saveToFavorites(session.getPlayer().getCurrentMediaItem());
return Futures.immediateFuture(new SessionResult(SessionResult.RESULT_SUCCESS));
}
return MediaSession.Callback.super.onCustomCommand(
session, controller, customCommand, args);
}
}
}
Note, I cannot test in the demo app as
./gradlew :demo:installNoDecoderExtensionsDebug
fails due to missing ./gradlew and
gradle init
fails with
> Plugin with id 'com.android.application' not found.
Expected result
Heart icon should show in the media3 notification
Actual result
Heart icon does not show in the media3 notification
Media
Any media file works
Bug Report
- You will email the zip file produced by
adb bugreportto android-media-github@google.com after filing this issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.