When is the right moment to call AdPlaybackState.withPlayedAd
Open
@marcbaechinger is already working on this.
Since May 19, 2025.
question
- Dominant language
- Java
- Stars
- 3k
- Forks
- 955
- Avg merge
- 12d 14h
- Merged PRs (30d)
- 2
Description
We noticed that if we don't call AdPlaybackState.withPlayedAd after an ad is finished the same ad loops forever. Is this expected?
Right now we call that after ExoPlayer.Listener.onTimelineChanged and ExoPlayer.Listener.onPositionDiscontinuity in case if reason is Player.DISCONTINUITY_REASON_AUTO_TRANSITION or newPosition.adIndexInAdGroup has changed, is that correct?
I'm asking this because we are reported that in some cases the same ad starts looping endlessly, and our best guess is that withPlayedAd call time is the culprit here...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.