androidx / androidx/media

Rewind and Forward buttons ids changed with media3 update from 1.3.1 to 1.4.1

Open
#1,747 9 comments 0 reactions 1 assignee View on GitHub

@oceanjules is already working on this.

Since Sep 21, 2024.

needs triage question
Dominant language
Java
Stars
3k
Forks
955
Avg merge
12d 14h
Merged PRs (30d)
2

Description

I updated media3 from 1.3.1 to 1.4.1 recently and it changed my rewind and forward buttons to the original ones.

I am guessing some ids might be changed as I am using my custom buttons but the id is not matching with the exoplayer ids

Xml buttons
<ImageButton
            android:id="@id/exo_rew"
            style="@style/PlayerControlButtonBaseStyle.RewButton" />
            
<ImageButton
            android:id="@id/exo_ffwd"
            style="@style/PlayerControlButtonBaseStyle.FfwdButton" />

Style File
<style name="PlayerControlButtonBaseStyle.RewButton">
        <item name="android:src">@drawable/exo_styled_controls_rewind</item>
    </style>

<style name="PlayerControlButtonBaseStyle.FfwdButton">
        <item name="android:src">@drawable/exo_styled_controls_fastforward</item>
</style>

I was not able to find anything releated to this in the release notes for 1.4.1 so if we have anything documented that I can refer so that the ids are correct on our side that would be really helpful.

Thank You.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.