Allow changing DefaultAudioSink.offloadMode
Open
@tonihei is already working on this.
Since Aug 2, 2022.
enhancement
- Dominant language
- Java
- Stars
- 3k
- Forks
- 955
- Avg merge
- 12d 14h
- Merged PRs (30d)
- 2
Description
Use case description
Audio offload may remove features such as volume normalization, gapless playback, playback speed.
If offload is provided as a user preference, it should be possible to change the mode in DefaultAudioSink without restarting to destroy the ExoPlayer instance and it's AudioSink.
Proposed solution
Allow changing the offload mode on an existing DefaultAudioSink, potentially only when not actively playing.
Alternatives considered
Some mechanism to tear down an ExoPlayer instance and rebuild it?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.