Add setSkipSilenceEnabled to Player interface
Open
@tonihei is already working on this.
Since Jan 26, 2024.
enhancement
- Dominant language
- Java
- Stars
- 3k
- Forks
- 955
- Avg merge
- 12d 14h
- Merged PRs (30d)
- 2
Description
Version
Media3 1.2.1
More version details
No response
Devices that reproduce the issue
Not applicable
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Not tested
Reproduction steps
MediaController doesn't contain a "setSkipSilenceEnabled" method. The Player interface also doesn't have it, although it does have a default void onSkipSilenceEnabledChanged(boolean skipSilenceEnabled) {} in its Listener interface.
Expected result
There should be a way to call setSkipSilenceEnabled from the MediaController so we can enable and disable it as needed.
Actual result
There is no way to call it.
Media
Not applicable
Bug Report
- You will email the zip file produced by
adb bugreportto android-media-github@google.com after filing this issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.