android / android/vkquality

Unable to detect uppercase "DOCOMO" and lowercase "docomo"

Open
#2 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
73
Forks
18
PR merge metrics
No merged PRs in 30d

Description

Hello,

The system fails to detect devices listed when the case of "DOCOMO" is different (uppercase vs. lowercase).

I attempted to add the following device to the default list:

```
31,0,docomo,SO-41B,Sony,Xperia Ace II,3982-3985MB,Phone,Mediatek MT6765,Imagination Tech PowerVR GE8320 (680 MHz),720x1496,300,arm64-v8a;armeabi;armeabi-v7a,30;31;33,0%0%0%0%
```
I identified that the issue originates from a case-sensitive check in vkquality_matching.cpp:

```C++

if (brand_view == brand && device_view == device) {
```
After modifying the code to perform a case-insensitive comparison, the device was recognized and operated correctly.
```C++

if (to_lower(brand_view) == to_lower(brand) && device_view == device) {
```

Contributor guide

Open the contributing guide

Research direction

Read the case-sensitive brand and device comparison in vkquality_matching.cpp, along with the surrounding matching logic. Update the behavior so the listed device is recognized when the DOCOMO brand casing differs, then verify that the device is detected and operates correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
mobile-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.