android / android/tv-samples

[JetStream] Migrate the bringIntoViewIfChildrenAreFocused modifier from composed function to Modifier.Node

Open
#171 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
1.3k
Forks
396
PR merge metrics
No merged PRs in 30d

Description

- The `bringIntoViewIfChildrenAreFocused` modifier uses `composed` function.
- The `composed` function causes the whole modifier chain to be re-composed every time.
- The `bringIntoViewIfChildrenAreFocused` modifier should switch its implementation to Modifer.Node for better performance.

Contributor guide

Open the contributing guide

Research direction

Locate the bringIntoViewIfChildrenAreFocused definition in the JetStream sample and inspect nearby Modifier.Node implementations first. Migrate this modifier away from composed while preserving its behavior, then run the sample's available checks to confirm it still builds and the modifier works as before.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
mobile
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.