android / android/tv-samples

[JetStream] Movie card titles are no longer horizontally constraint.

Open
#144 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
1.3k
Forks
396
PR merge metrics
No merged PRs in 30d

Description

In the recent pull request https://github.com/android/tv-samples/pull/142 the explicit [width](https://github.com/android/tv-samples/pull/142/files#diff-0ce80aeb4da37b43fd50dec1fb00c50172fb17b2be0d95701fcabaa9669513fdL241) was removed from the modifier on the `StandardCardLayout` in the `common/Moviesrow.kt` file. This will cause the card to horizontally expand as needed to place the title of the item on the screen.

It is generally not noticeable in the sample as all the movie titles in movies.json are small enough but as the screenshot below shows longer titles will cause issues.

![Screenshot_20231212_113257](https://github.com/android/tv-samples/assets/516028/46366e7a-22f4-4054-ac8e-33d01e8d0916)

Contributor guide

Open the contributing guide

Research direction

Start in common/Moviesrow.kt at the StandardCardLayout modifier, then compare the related change in pull request 142. Verify the behavior with a movie title longer than those in movies.json; done means the card keeps a constrained width and the title no longer expands the card horizontally.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.