android / android/tuningfork

I can't see the LoadingTime record in the dashboard

Open
#38 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
62
Forks
33
PR merge metrics
No merged PRs in 30d

Description

Hi

I used android performance tuner 1.5.2 version

create custom Annotation and record LoadingGroup and LoadingTime

like this

```csharp

// StartLoadingGroup
LoadingTimeMetadata groupMetadata = new LoadingTimeMetadata() {
state = LoadingTimeMetadata.LoadingState.FirstRun,
source = LoadingTimeMetadata.LoadingSource.UnknownSource,
};
var groupResult = Tuner?.StartLoadingGroup(groupMetadata, null);

// StartRecordingLoadingTime
LoadingTimeMetadata metadata = new LoadingTimeMetadata() {
state = LoadingTimeMetadata.LoadingState.FirstRun,
source = LoadingTimeMetadata.LoadingSource.UnknownSource,
};
Annotation annotation = new Annotation() {
PlatformInit = PhaseNameToEnum(phaseName)
};
var result = Tuner?.StartRecordingLoadingTime(metadata, annotation);

// StopRecordingLoadingTime
var stopErrorCode = Tuner?.StopRecordingLoadingTime(result.value);

// StopLoadingGroup
var stopErrorCode = Tuner.StopLoadingGroup(groupResult.value);

```

and since the release product, I can see the frame, but not the LoadingTime record in the dashboard

my guess is that tuningfork.proto is missing from the Unity Package, and that in order to make ProjectData.hasLoadingState true,

we need to modify the LoadingAnnotationIndex in tuningfork.proto and compile via protoc

tuningfork.proto's LoadingAnnotationIndex to make ProjectData.hasLoadingState true.

but for now, ProjectData.hasLoadingState is false.

Am I missing something?

Contributor guide

Open the contributing guide

Research direction

Start by checking the Unity package for tuningfork.proto and tracing LoadingAnnotationIndex into ProjectData.hasLoadingState. Compare this with the LoadingTime dashboard record path and the shown recording calls. The work is done when the required definition is present, hasLoadingState is correctly set, and the LoadingTime record appears in the dashboard.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, csharp, unity
Domain
mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.