android / android/snippets

Inconsistent API

Open
#755 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
1.1k
Forks
419
Avg merge
3d 18h
Merged PRs (30d)
28

Description

`GlanceAppWidgetManager` requires using `::class.java` in some methods and `::class` in others

I guess it's safe to assume nobody is going to be using that API from Java, so `KClass` should be used consistently?

`androidx.glance.appwidget.GlanceAppWidgetManager#requestPinGlanceAppWidget` is one of the offending functions

Contributor guide

Open the contributing guide

Research direction

Start by inspecting the androidx.glance.appwidget.GlanceAppWidgetManager API, especially requestPinGlanceAppWidget, and compare the parameter types used by its other methods. Confirm which Kotlin class-reference form the API should expose and check the surrounding declarations for consistency; done means the relevant methods use the agreed form consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
api, mobile-dev
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.