android / android/performance-samples
JankStatsAggregator.issueJankReport concurrency issues
- Dominant language
- Kotlin
- Stars
- 1.4k
- Forks
- 250
- Avg merge
- 9m
- Merged PRs (30d)
- 4
Description
The example JankStatsAggregator class can produce `ConcurrentModificationException` for listeners that perform some additional operations on it. Presumably because of how FrameData objects are internally mutated.
It appears that JankStatsAggregator.issueJankReport attempts to account for that with copies, but it may not be fully thread safe.
For example:
```
private val reportListener = JankStatsAggregator.OnJankReportListener { _, _, jankFrameData ->
jankFrameData.filter(...).map { frame ->
// Do something with FrameData and/or StateInfo
}
}
```
This usage results in rare concurrency exceptions. I'm not sure if it is a misusage on my end, but as a user I would expect the listener to be thread safe.
Contributor guide
Assessment
This issue has not been assessed yet.