android / android/nowinandroid

[Bug]: Unused binds in TestDataModule

Open
#709 7 comments 0 reactions 1 assignee Claimed by @mmoczkowski View on GitHub
refactor
Dominant language
Kotlin
Stars
21.8k
Forks
4.6k
Avg merge
19h 20m
Merged PRs (30d)
2

Description

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Is there a StackOverflow question about this issue?

- [X] I have searched StackOverflow

### What happened?

There are some repository binds in TestDataModule that are not provided or injected anywhere in the app, so you've got some FakeRepository classes sitting idle e.g FakeTopicsRepository

Instead, you are using test doubles data sources e.g TestNiaNetworkDataSource where you create a fake data source e.g FakeNiaNetworkDataSource from the network module.

`package com.google.samples.apps.nowinandroid.core.data.test.TestDataModule`

Thanks
Patryk

### Relevant logcat output

_No response_

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.